coolbeevip commented on a change in pull request #2347:
URL: https://github.com/apache/bookkeeper/pull/2347#discussion_r429918765
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
##########
@@ -125,6 +135,8 @@ private static ServerConfiguration parseArgs(String[] args)
ServerConfiguration conf = new ServerConfiguration();
+ loadConfEnv(conf);
+
if (cmdLine.hasOption('c')) {
String confFile = cmdLine.getOptionValue("c");
loadConfFile(conf, confFile);
Review comment:
> Please add a command line option.
>
> Otherwise with this change we are introducing unexpected behaviour and
possibly a security issue.
Use the command-line option `env`, What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
