coolbeevip commented on a change in pull request #2347:
URL: https://github.com/apache/bookkeeper/pull/2347#discussion_r429763019
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##########
@@ -224,6 +227,19 @@ public void loadConf(URL confURL) throws
ConfigurationException {
}
}
+ /**
+ * Load configurations from environment variables prefixed with BK_.
+ */
+ public void loadEnv() {
Review comment:
> I am not sure this is the best place to put this code.
> This is the configuration for the client as well.
> I suggest to put this block into Main.java? This way it is specific to the
bookie bootstrap procedure.
If this block is put into Main.java, it cannot be reused with
LocalBookKeeper :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
