Ghatage commented on a change in pull request #2355:
URL: https://github.com/apache/bookkeeper/pull/2355#discussion_r436318219
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java
##########
@@ -635,6 +635,47 @@ public void
testBookieAuthPluginRequireClientTLSAuthenticationLocal() throws Exc
assertTrue(cert instanceof X509Certificate);
}
+ /**
+ * Verify that given role in client certificate is checked when
BookieAuthZFactory is set.
+ * Positive test case where all given roles are present.
Review comment:
If `testClient()` fails, it will be because of an exception thrown
during Authorization.
And hence we catch that and fail the test.
Otherwise, if the test passes, it never reaches the `catch` block and
finishes, passing the test
Sorry for the confusing comment, I can change that in a follow up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
