eolivelli commented on a change in pull request #2355:
URL: https://github.com/apache/bookkeeper/pull/2355#discussion_r442005521
##########
File path: conf/bk_server.conf
##########
@@ -226,6 +226,15 @@
httpServerClass=org.apache.bookkeeper.http.vertx.VertxHttpServer
#
# permittedStartupUsers=
+# Certificate role based authorization for Bookie
+# To enable this option, bookieAuthProviderFactoryClass should be set to
org.apache.bookkeeper.tls.BookieAuthZFactory
+# comma separated values of roles from the certificates OU field which we want
to authorize for access
+#
+# Example settings:
+# authorizedRoles=apache-pulsar-cluster-12,apache-kafka-cluster-2
Review comment:
please remove it
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java
##########
@@ -635,6 +635,47 @@ public void
testBookieAuthPluginRequireClientTLSAuthenticationLocal() throws Exc
assertTrue(cert instanceof X509Certificate);
}
+ /**
+ * Verify that given role in client certificate is checked when
BookieAuthZFactory is set.
+ * Positive test case where all given roles are present.
Review comment:
yes please update the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
