Ghatage commented on pull request #2355: URL: https://github.com/apache/bookkeeper/pull/2355#issuecomment-646489892
Hey @eolivelli, I've made the following changes as requested: * Added a test class for `BookieAuthZFactory` which doesn't spin up a bookie cluster. * Added all negative test cases to the above new test class. * Removed the 'heavy' negative test case from `TestTLS` class. * Modified comment to explain the success case better. * Converted `CertUtils` class to abstract with a private default constructor. * Removed unrelated comments from `bk_server.conf` * Added `isAuthenticated()` method to authProvider Feature wise this is complete and switched off by default. Lastly, once the CI tests pass, it's best to hold off on merging this before 4.11 is cut and released as discussed in the mailing list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
