dlg99 commented on a change in pull request #2801:
URL: https://github.com/apache/bookkeeper/pull/2801#discussion_r714475685
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestPerChannelBookieClient.java
##########
@@ -314,7 +314,7 @@ public void testEpollChannelTcpUserTimeout() throws
Exception {
EventLoopGroup eventLoopGroup = new EpollEventLoopGroup();
OrderedExecutor executor = getOrderedSafeExecutor();
ClientConfiguration conf = new ClientConfiguration();
- int tcpUserTimeout = 1234;
+ int tcpUserTimeout = 1236; // this value may be rounded on some Linux
implementations
Review comment:
Another suspect is that
[TCP_USER_TIMEOUT](https://man7.org/linux/man-pages/man7/tcp.7.html)
(tcpUserTimeout feeds into it) is `unsigned int` but netty's interface to jni
passes it as it is jint:
https://github.com/netty/netty/blob/23405e2000427e9cad104913e7071d8d08e91a3c/transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c#L144-L146
i.e. for multicast netty casts parameter to `u_int`:
https://github.com/netty/netty/blob/23405e2000427e9cad104913e7071d8d08e91a3c/transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c#L78-L81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
