eolivelli commented on a change in pull request #2801:
URL: https://github.com/apache/bookkeeper/pull/2801#discussion_r715324160



##########
File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestPerChannelBookieClient.java
##########
@@ -314,7 +314,7 @@ public void testEpollChannelTcpUserTimeout() throws 
Exception {
         EventLoopGroup eventLoopGroup = new EpollEventLoopGroup();
         OrderedExecutor executor = getOrderedSafeExecutor();
         ClientConfiguration conf = new ClientConfiguration();
-        int tcpUserTimeout = 1234;
+        int tcpUserTimeout = 1236; // this value may be rounded on some Linux 
implementations

Review comment:
       The other cure for this problem is to revert the change at all.
   
   @RaulGracia said that in the test environments this feature is a good 
enhancement and fixes a problem.
   
   So probably we can change the test to set a value that is likely to be used 
in production.
   If Netty/Linux or other parts om the stack do not preserve every value it is 
not a BK problem.
   We can open a ticket on Netty, I am pretty sure that we cannot so anything 
in BK.
   
   I want to fix this test that is consistently failing and it is blocking some 
CI pipeline.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to