dlg99 commented on a change in pull request #2801:
URL: https://github.com/apache/bookkeeper/pull/2801#discussion_r714994150
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestPerChannelBookieClient.java
##########
@@ -314,7 +314,7 @@ public void testEpollChannelTcpUserTimeout() throws
Exception {
EventLoopGroup eventLoopGroup = new EpollEventLoopGroup();
OrderedExecutor executor = getOrderedSafeExecutor();
ClientConfiguration conf = new ClientConfiguration();
- int tcpUserTimeout = 1234;
+ int tcpUserTimeout = 1236; // this value may be rounded on some Linux
implementations
Review comment:
TBH I do not know.
I experimented with endianness conversion, neither 1234 nor 1236 seem
problematic or radically different, even if I add casting to unsigned int.
OTOH, TCP_USER_TIMEOUT is defined as a 15bit unsigned in the RFC but I don't
think 15 vs 16bit matters for either value.
but extra 2ms timeout making the test pass makes even less sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
