nicoloboschi commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714535876
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -2524,6 +2528,41 @@ public long getAuditorPeriodicReplicasCheckInterval() {
return getLong(AUDITOR_REPLICAS_CHECK_INTERVAL, 0);
}
+ /**
+ * Get the semaphore limit value of getting ledger from zookeeper in auto
recovery.
+ *
+ * @return The semaphore value. By default it is 500.
+ */
+ public int getAuditorMaxNumberOfConcurrentOpenLedgerOperations() {
+ return getInt(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS,
500);
+ }
+
+ /**
+ * Set the semaphore limit value for getting ledger from zookeeper in auto
recovery.
+ * @param semaphore
+ */
+ public void setAuditorMaxNumberOfConcurrentOpenLedgerOperations(int
semaphore) {
+ setProperty(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS,
semaphore);
+ }
+
+ /**
+ * Get the acquire concurrent open ledger operations timeout.
+ *
+ * @return The timeout values. By default it is 30s
Review comment:
30 or 120? i think the value should be in ms rather than seconds
##########
File path: conf/bk_server.conf
##########
@@ -875,6 +875,13 @@ zkEnableSecurity=false
# the provided digest type provided at `digestType` and the provided passwd
provided at `passwd`.
# enableDigestTypeAutodetection=true
+# Semaphore limit of getting ledger from zookeeper. Used to throttle the
zookeeper client request operation
+# sending to Zookeeper server. Default value is 500
+# auditorMaxNumberOfConcurrentOpenLedgerOperations=500
+
+# Wait time out of acquiring semaphore of concurrent open ledger operations.
Default value is 120s.
Review comment:
timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
