hangc0276 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r715267341
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1266,23 @@ void checkAllLedgers() throws BKException, IOException,
InterruptedException, Ke
return;
}
+ try {
+ if
(!openLedgerNoRecoverySemaphore.tryAcquire(openLedgerNoRecoverySemaphoreWaitTimeoutMSec,
Review comment:
The default zk client timeout is 10s, if set to 2 * zkTimeout, it will
be 20s.
However, in the replicas check process, it use
`REPLICAS_CHECK_TIMEOUT_IN_SECS=120` as maxConcurrentSemaphore tryAcquire
timeout.
So i doubt whether put `openLedgerNoRecoverySemaphoreWaitTimeoutMSec` in to
`bk_server.conf` or just hard code to `2 * zkTimeout` and the default value set
to 120s or not.
@dlg99 Would you please give me some ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
