dlg99 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r715048102



##########
File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1266,23 @@ void checkAllLedgers() throws BKException, IOException, 
InterruptedException, Ke
                     return;
                 }
 
+                try {
+                    if 
(!openLedgerNoRecoverySemaphore.tryAcquire(openLedgerNoRecoverySemaphoreWaitTimeoutMSec,

Review comment:
       I think openLedgerNoRecoverySemaphoreWaitTimeoutMSec can be safely set 
to zk client timeout, or 2x of that timeout 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to