RaulGracia commented on pull request #2838: URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-950622773
Thanks @zymap, I think that the problem may be as follows: - The comments in the original PR #2816 suggested to remove Log4j bindings from `bookkeeper-common` and `bookkeeper-server` (at least from the main code). - I have been able to do that for `bookkeeper-common`. - I have done the same for `bookkeeper-server`. However, it looks like this module was importing (even before PR #2816) some of these binding dependencies, given that when I remove them, integration tests fail. The failures are related to some tests that relay on the log output to validate `bkctl` commands. I will work on finding the best way to make `bkctl` to have the necessary log4j dependencies, while removing them from `bookkeeper-server`, as this was the original comment. My only concern is whether or not there could be more modules relying on the log4j bindings in the same way as `bkctl` tests do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
