pkumar-singh commented on pull request #2838: URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-951176472
Looks good to me. Approved. Thanks -Prashant. On Mon, Oct 25, 2021 at 10:52 AM Raúl Gracia ***@***.***> wrote: > @eolivelli <https://github.com/eolivelli> @pkumar-singh > <https://github.com/pkumar-singh> @zymap <https://github.com/zymap> I > think that this PR now addresses the original comment > <https://github.com/apache/bookkeeper/pull/2816#discussion_r729987757> > that suggested that we should not be bringing log implementation bindings > in neither bookkeeper-server and bookkeeper-common. Note that for > bookkeeper-common this was true, but I think that was not the case for > bookkeeper-server (as visible, FileSystemUpgrade class was using log4j > APIs within bookkeeper-server main code). I have set this PR ready to > review, so it would be great to get your feedback about it. > > Also, this PR has been tagged as version 4.14.3, but I think that this is > not correct; This PR is related to PR #2816 > <https://github.com/apache/bookkeeper/pull/2816> that targets 4.15 > (current master). > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/bookkeeper/pull/2838#issuecomment-951162401>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/APQ5IN4KNKOFRE633ZADN53UIWKMTANCNFSM5GIT2YDQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
