RaulGracia commented on pull request #2838: URL: https://github.com/apache/bookkeeper/pull/2838#issuecomment-951162401
@eolivelli @pkumar-singh @zymap I think that this PR now addresses the [original comment](https://github.com/apache/bookkeeper/pull/2816#discussion_r729987757) that suggested that we should not be bringing log implementation bindings in neither `bookkeeper-server` and `bookkeeper-common`. Note that for `bookkeeper-common` this was true, but I think that was not the case for `bookkeeper-server` (as visible, `FileSystemUpgrade` class was using log4j APIs within `bookkeeper-server` main code). I have set this PR ready to review, so it would be great to get your feedback about it. Also, this PR has been tagged as version 4.14.3, but I think that this is not correct; This PR is related to PR #2816 that targets 4.15 (current `master`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
