pkumar-singh commented on a change in pull request #2850:
URL: https://github.com/apache/bookkeeper/pull/2850#discussion_r735851080
##########
File path: bin/common.sh
##########
@@ -257,7 +258,7 @@ set_module_classpath() {
echo ${BK_CLASSPATH}
else
add_maven_deps_to_classpath ${MODULE_PATH} >&2
- cat ${BK_HOME}/${MODULE_PATH}/target/cached_classpath.txt
+ cat ${BK_HOME}/${MODULE_PATH}/${PROJECT_TARGET_DIR}/cached_classpath.txt
Review comment:
You should use bin/common_gradle.sh and bin/bookkeepr_gradle.
This change will break maven.
Idea is not touch maven for now. Because there could be people developing
and running bookkeeper locally with maven.
When we finally shutdown maven for good. Then we will rename
bin/common_gradle to bin/common and bin/bookkeeper_gradle to bin/bookkeeper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
