pkumar-singh commented on a change in pull request #2850:
URL: https://github.com/apache/bookkeeper/pull/2850#discussion_r736763095
##########
File path: bin/common_gradle.sh
##########
@@ -213,21 +213,16 @@ find_module_jar() {
echo "Could not find module '${MODULE_JAR}' jar." >&2
exit 1
fi
- ##echo ${MODULE_JAR}
+ echo "${MODULE_JAR}"
return
}
add_maven_deps_to_classpath() {
MODULE_PATH=$1
- MVN="mvn"
- if [ "$MAVEN_HOME" != "" ]; then
- MVN=${MAVEN_HOME}/bin/mvn
- fi
-
# Need to generate classpath from maven pom. This is costly so generate it
# and cache it. Save the file into our target dir so a mvn clean will get
# clean it up and force us create a new one.
- f="${BK_HOME}/${MODULE_PATH}/build/classpath.txt"
+ f="${BK_HOME}/${MODULE_PATH}/build/cached_classpath.txt"
Review comment:
I think change will break what was fixed with this PR.
https://github.com/apache/bookkeeper/pull/2841
Basically try and see whether we are able to bring up local bookkeeper.
Build using gradle ./gradlew build -x test -x checkstyleMain -x
checkstyleTest -x spotbugsTest -x spotbugsMain -x rat -x signDistTar
Try and run
bin/bookkeeper standalone
Thing is there is no need for touching common_gradle. Except probably
getting rid of
code block.
MVN="mvn"
if [ "$MAVEN_HOME" != "" ]; then
MVN=${MAVEN_HOME}/bin/mvn
fi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
