pkumar-singh commented on a change in pull request #2850:
URL: https://github.com/apache/bookkeeper/pull/2850#discussion_r736808195
##########
File path: tests/scripts/src/test/bash/bk_test_bin_common.sh
##########
@@ -19,6 +19,16 @@
# * See the License for the specific language governing permissions and
# * limitations under the License.
# */
+PROJECT_BUILD_SYSTEM=${PROJECT_BUILD_SYSTEM:-maven}
Review comment:
Typically I would not bother for creating common script for gradle and
maven. I would suggest leaving maven one alone and have a duplicate for gradle.
That's what I have been following that serves three purposes.
- I do not have to worry about breaking Maven. Because I am not touching it.
- I do not have to spend any time writing code which should work for maven
and gradle, because we will remove maven in a week or two.
- I do not have to remember removing code written for maven in a week or
two. Because they had always been separate file. All we have to do is to rename
tests/scripts/src/test/bash/bk_test_bin_common_gradle.sh to
tests/scripts/src/test/bash/bk_test_bin_common.sh
Downside is: Duplicate file for gradle until maven is finally removed.
Just my suggestion. Not a PR blocker at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
