pradeepbn commented on a change in pull request #2868:
URL: https://github.com/apache/bookkeeper/pull/2868#discussion_r739450756
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageTest.java
##########
@@ -238,6 +238,17 @@ public void testBookieCompaction() throws Exception {
assertEquals(newEntry3, res);
}
+ @Test
+ public void testReadsOpAfterShutdown() throws Exception {
+ SingleDirectoryDbLedgerStorage singleDirStorage = ((DbLedgerStorage)
storage).getLedgerStorageList().get(0);
+ singleDirStorage.shutdown();
Review comment:
@eolivelli Handled the idempotency case in the latest fix. However,
shutdown() on the storage itself must be made idempotent. I will create a
separate issue to handle that situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
