pradeepbn commented on a change in pull request #2868:
URL: https://github.com/apache/bookkeeper/pull/2868#discussion_r739451290
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageTest.java
##########
@@ -238,6 +238,17 @@ public void testBookieCompaction() throws Exception {
assertEquals(newEntry3, res);
}
+ @Test
+ public void testReadsOpAfterShutdown() throws Exception {
+ SingleDirectoryDbLedgerStorage singleDirStorage = ((DbLedgerStorage)
storage).getLedgerStorageList().get(0);
+ singleDirStorage.shutdown();
+ try {
+ ByteBuf res = singleDirStorage.getEntry(4, 3);
+ } catch (IOException e) {
+ // This will pass the test since it is expected to throw
IOException
Review comment:
Done with the latest fix
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/ReadCache.java
##########
@@ -76,18 +82,24 @@ public ReadCache(ByteBufAllocator allocator, long
maxCacheSize, int maxSegmentSi
cacheSegments.add(Unpooled.directBuffer(segmentSize, segmentSize));
cacheIndexes.add(new ConcurrentLongLongPairHashMap(4096, 2 *
Runtime.getRuntime().availableProcessors()));
}
+ isStorageShutdown = false;
}
@Override
public void close() {
cacheSegments.forEach(ByteBuf::release);
+ isStorageShutdown = true;
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
