lhotari commented on pull request #3110:
URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1067608248


   Thanks @congbobo184 for making this PR.
   
   I'm just wondering that `close` should get called once as a result of the 
guard by `org.apache.bookkeeper.client.PendingReadOp`'s `AtomicBoolean 
complete` field:
   
   
https://github.com/apache/bookkeeper/blob/10825c93bccd9e170df75ab9f2cf85cb6043f649/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java#L619-L622
   
   Why isn't that sufficient?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to