hangc0276 commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1067634348
> Why isn't the `if (!complete.compareAndSet(false, true)) {` sufficient in PendingReadOp#submitCallback? @lhotari The `if (!complete.compareAndSet(false, true)) {` in PendingReadOp#submitCallback just change the complete flag in PendingReadOp instance. But the ``` if (complete.compareAndSet(false, true)) { entryImpl.close(); } ``` Change the `complete` flag in LedgerEntryRequest. They are different instances. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org