lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1067642520
> Change the `complete` flag in LedgerEntryRequest. They are different instances. yes, I have noticed that there's 2 separate `complete` fields: `org.apache.bookkeeper.client.PendingReadOp#complete` and `org.apache.bookkeeper.client.PendingReadOp.LedgerEntryRequest#complete`. https://github.com/apache/bookkeeper/blob/017307bc67431a7616861ad09927c4e3327633d1/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java#L58-L84 That doesn't change my original question: LedgerEntryRequest.close seems to only get called via call chains originating from PendingReadOp.submitCallback, why isn't the PendingReadOp's complete field preventing the duplicate calls to LedgerEntryRequest.close ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
