lhotari edited a comment on pull request #3110:
URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1068136249
I now see the reason why Congbo chose to implement it using
```java
public void close() {
complete.set(true);
entryImpl.close();
}
```
That seems to be made this way since `entryImpl.close()` should be called
when `close` is called regardless of whether the complete has been set to true.
The reason to set complete to true is to prevent using `entryImpl` after
close has been called.
This feels like using `complete` field isn't the correct solution for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
