congbobo184 commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1068804935
@dlg99 hi, 1. although `ListenerBasedPendingReadOp` don't close all ledgerEntryRequset, we only change complete, it will not change any logical for `ListenerBasedPendingReadOp`, we can fix `ListenerBasedPendingReadOp` in next pr, not in this PR 2. it will not memory leak when don't not recycle entry's writeSet. now in this PR we only fix LedgerEntryImpl.close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
