congbobo184 edited a comment on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1068798062
https://github.com/apache/bookkeeper/blob/e99cd4915b56ae3e9891ef9a83eb5e8f089505d7/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java#L146 complete will be changed in this way and then close will not close ledgerEntryImpl if you use compareAndSet https://github.com/apache/bookkeeper/blob/e99cd4915b56ae3e9891ef9a83eb5e8f089505d7/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java#L169 if read fail, in this way we already change complete, so close will not do anything. @lhotari @nicoloboschi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
