hangc0276 commented on code in PR #3212:
URL: https://github.com/apache/bookkeeper/pull/3212#discussion_r857122376
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -2395,6 +2396,27 @@ public boolean isReadOnlyModeEnabled() {
return getBoolean(READ_ONLY_MODE_ENABLED, true);
}
+ /**
+ * Set whether the bookie is able to go into read-only mode when any disk
is full.
+ * If this set to false, it will behave to READ_ONLY_MODE_ENABLED flag.
+ *
+ * @param enabled whether to enable read-only mode when any disk is full.
+ * @return
+ */
+ public ServerConfiguration setReadOnlyModeOnAnyDiskFullEnabled(boolean
enabled) {
+ setProperty(READ_ONLY_MODE_ON_ANY_DISK_FULL_ENABLED, enabled);
+ return this;
+ }
+
+ /**
+ * Get whether read-only mode is enable when any disk is full. The default
is false.
+ *
+ * @return boolean
+ */
+ public boolean isReadOnlyModeOnAnyDiskFullEnabled() {
+ return getBoolean(READ_ONLY_MODE_ON_ANY_DISK_FULL_ENABLED, false);
Review Comment:
If we enable is feature, it changed the current behavior. I wonder if we
make the default false first, and send an email to dev mail list to discuss it.
If approved, I use another PR to change the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
