hangc0276 commented on PR #3212: URL: https://github.com/apache/bookkeeper/pull/3212#issuecomment-1109412096
> I'll look at the change a little bit later, but the first thing I noticed is that the new config option is not added to/not documented at the `conf/bk_server.conf` and not added to the docs. IMO, we'd better to keep `conf/bk_server.conf` simple and just include import config. For advanced users who want to change chose config item, they can get the description from `ServerConfiguration.java`. Just like Apache Pulsar, we put all the config item into the `conf/broker.conf`, leading to nearly 1k lines of the configuration file. For common users, they will be confused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
