hangc0276 commented on PR #3212: URL: https://github.com/apache/bookkeeper/pull/3212#issuecomment-1111675467
> Overall: LGTM. > > I still insist on updating config file with description of the feature + the docs. > > @hangc0276 I hear your point about the length of the file but there are other things to consider: > > * On many occasions doc were out of sync and config works a s a more up-to-date version of the doc > * config is easy to diff against an existing prod config to check if there are any new features one wants to try, how the current one is different form defaults etc. Diffing code is a bit more painful, especially considering that here is ServerConfiguration, AbstractConfiguration etc > * new user is unlikely to start digging into the code to look for the config options > * currently community agreement, as I remember, is to add new options and their description into the config file. You can start a discussion on ML to challenge this but we'll need to come up with a better solution for options discoverability than forcing users to dig into the code. @dlg99 I have update the doc, Please help take a look, thanks a lot. I wonder if we can include this Pr into 4.15.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
