[ 
https://issues.apache.org/jira/browse/CALCITE-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032359#comment-15032359
 ] 

Julian Hyde commented on CALCITE-996:
-------------------------------------

I concur with [~vlsi]'s review comment that we need a test case. It would help 
me understand why you want this. I had thought that RelBuilder.filter was 
already simplifying - but I now see that it is not. Why not make 
RelBuilder.filter always simplify?

If you modify RelBuilder.filter, then a test case in RelBuilderTest will be 
sufficient.

> FilterMergeRule should simplify the merged condition
> ----------------------------------------------------
>
>                 Key: CALCITE-996
>                 URL: https://issues.apache.org/jira/browse/CALCITE-996
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 1.6.0
>
>
> When we call FilterMergeRule, there is a high probability that we end up with 
> duplicate predicate factors. It seems appropriate to simplify the predicate 
> to eliminate those factors before we create the merged filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to