[ 
https://issues.apache.org/jira/browse/CALCITE-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032387#comment-15032387
 ] 

Julian Hyde commented on CALCITE-996:
-------------------------------------

I too am usually worried about overhead. However, the overhead is a quick 
{{switch (node.getKind())}} for each conjunction, followed by {{simplifyAnd}} 
applied to the list of conjunctions, which, if the expression has already been 
simplified and has no NOTs, is hardly slower than the {{composeConjunction}} 
that {{filter}} calls anyway.

> FilterMergeRule should simplify the merged condition
> ----------------------------------------------------
>
>                 Key: CALCITE-996
>                 URL: https://issues.apache.org/jira/browse/CALCITE-996
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 1.6.0
>
>
> When we call FilterMergeRule, there is a high probability that we end up with 
> duplicate predicate factors. It seems appropriate to simplify the predicate 
> to eliminate those factors before we create the merged filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to