[ 
https://issues.apache.org/jira/browse/CALCITE-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032378#comment-15032378
 ] 

Jesus Camacho Rodriguez commented on CALCITE-996:
-------------------------------------------------

[~julianhyde], [~vlsi], thanks for the comments. I agree with you, we need a 
test case; I'll add it so you can see clearly the purpose of the improvement 
and check its correctness.

I could delegate the check to RelBuilder.filter indeed, though I am afraid we 
might be introducing an unnecessary overhead in many cases; that is why I think 
it is better to keep it in FilterMergeRule.

> FilterMergeRule should simplify the merged condition
> ----------------------------------------------------
>
>                 Key: CALCITE-996
>                 URL: https://issues.apache.org/jira/browse/CALCITE-996
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 1.6.0
>
>
> When we call FilterMergeRule, there is a high probability that we end up with 
> duplicate predicate factors. It seems appropriate to simplify the predicate 
> to eliminate those factors before we create the merged filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to