[
https://issues.apache.org/jira/browse/CALCITE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122284#comment-15122284
]
Josh Elser commented on CALCITE-642:
------------------------------------
Thanks for taking a look, Julian.
bq. Change the commit description to make clear you're adding to Avatica
*server*. We don't need dependency bloat in the client.
So, this isn't entirely true. We have some code which is only intended to run
in the server, but lives in the "client" package, e.g. {{JsonHandler}} handles
the serialization into POJOs. The dropwizard-metrics artifact itself is only
110KB in size, ~100classes and the only provided reporter is an slf4j one
(suddenly the slf4j work becomes more important). Long term, I think having the
ability to use this metrics instrumentation to measure things in the client is
valuable as well (but is presently left as a "todo"). Looks like the
calcite-avatica jar is at ~3.5MB with these changes.
Is including this dependency in the calcite-avatica a deal-breaker for you?
Restructuring stuff for avatica has been on my radar (notably the splitting up
of Service and the POJOs), but I didn't want to try to tackle both of these at
once.
bq. Add a small section to http://calcite.apache.org/docs/avatica_overview.html
and add the package to the "structure" section
Ahh, thanks for the reminder. I meant to write up some docs for users too.
bq. Move the version number in pom.xml into the properties list (consistent
with what I did in CALCITE-999)
Will do.
> Avatica server metrics
> ----------------------
>
> Key: CALCITE-642
> URL: https://issues.apache.org/jira/browse/CALCITE-642
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Nick Dimiduk
> Assignee: Josh Elser
> Labels: avatica
> Fix For: next
>
>
> Along the same lines as CALCITE-641, avatica server should track some basic
> metrics. We can expose them through a "standard" API (such as Hadoop metrics,
> or Dropwizard metrics), and include them on some interval in the service log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
