[
https://issues.apache.org/jira/browse/CALCITE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126841#comment-15126841
]
Josh Elser commented on CALCITE-642:
------------------------------------
Just pushed a big changeset to the pull request. It was a long road around, but
I think I'm happy with where we ended up:
* Introduced an avatica-metrics API which is all that avatica (client) depends
on. This includes a "noop" implementation which removed lots of null/optional
checking.
* Introduced a dropwizard-metrics v3 implementation of avatica-metrics.
* ServiceLoader is used to find one (and only one) implementation. Otherwise
the noop implementation is used. (the noop implementation doesn't have a
META-INF/services entry for this)
* Also included the dropwizard-metrics to hadoop metrics2 as a standalone
module in calcite (my glance upstream at dropwizard showed that the next
version will be 4.y.z and includes a package renaming -- I'm hoping we can act
as the host for this code until we get it pushed upstream and it can flourish
there).
* Lots of tests
One thing I avoided was making a new avatica shaded jar with the metrics
implementation included. This really boiled down to a new dependency in the
downstream project (phoenix), so I was OK with this for now. More use by
consumers other than myself will tell.
[~julianhyde], if you'd like to look at the change before I merge, let me know.
I believe this approach should be satisfactory to your already-stated concerns.
I'm waiting to get a positive from travis (or at least what Travis would run
itself).
> Avatica server metrics
> ----------------------
>
> Key: CALCITE-642
> URL: https://issues.apache.org/jira/browse/CALCITE-642
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Nick Dimiduk
> Assignee: Josh Elser
> Labels: avatica
> Fix For: next
>
>
> Along the same lines as CALCITE-641, avatica server should track some basic
> metrics. We can expose them through a "standard" API (such as Hadoop metrics,
> or Dropwizard metrics), and include them on some interval in the service log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
