[
https://issues.apache.org/jira/browse/CALCITE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131639#comment-15131639
]
Josh Elser commented on CALCITE-642:
------------------------------------
First off, thanks a bunch for taking a look at this, Julian. I really do
appreciate another set of eyes on it.
bq. Do we need any of those log4j.properties files? A bad log4j.properties
crept onto my classpath recently and was burning masses of CPU. I had to nuke
my sandbox.
Wowza. I was trying to think how they could affect anything. I guess how we do
some of the test-jar dependencies, it could happen. That isn't relevant for the
ones I introduced here (calcite-core would be an issue).
bq. We now use properties for version numbers in POMs
Ah, forgot to remove that one.
bq. I didn't know you could remove version number from a pom.xml and inherit it
from the parent
Inherits from the parent pom :). Eclipse was giving me a yellow squiggly line
and it was bothering me.
bq. You could make Timer.Context implement Closeable (Dropwizard's Context
does) or AutoCloseable, then try-with-resources will call stop automatically
Good suggestion.
I'll fix up these last things and then squash/merge tomorrow!
> Avatica server metrics
> ----------------------
>
> Key: CALCITE-642
> URL: https://issues.apache.org/jira/browse/CALCITE-642
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Nick Dimiduk
> Assignee: Josh Elser
> Labels: avatica
> Fix For: next
>
>
> Along the same lines as CALCITE-641, avatica server should track some basic
> metrics. We can expose them through a "standard" API (such as Hadoop metrics,
> or Dropwizard metrics), and include them on some interval in the service log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
