[
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159240#comment-16159240
]
Julian Hyde commented on CALCITE-1913:
--------------------------------------
See my comment about "ends of the spectrum" on 1st August. Removing
DatabaseProduct, as you have done, causes the code to get a lot larger. I want
to keep it. We can stop people over-using it by careful review.
The benefit of DatabaseProduct is concreteness. It's often more concise to say
"this database behaves like Postgres in most respects". Conversely, it's not
obvious to me what the "supportsNullPrecedence()" method means, although I
would probably figure it out if I looked at the point at which it was used.
Regarding "mix-in interface". I was referring to
https://en.wikipedia.org/wiki/Mixin but maybe I wasn't using it correctly. It
seems to me that "sequence support" is not separate from "dialect". Some
dialects have sequence support, some don't. We can put the utility methods for
sequences in the base class, SqlDialect, and if that particular dialect doesn't
have sequences then it just won't use them.
> Include DB version in SqlDialect
> --------------------------------
>
> Key: CALCITE-1913
> URL: https://issues.apache.org/jira/browse/CALCITE-1913
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.13.0
> Reporter: Jess Balint
> Assignee: Jess Balint
> Priority: Minor
>
> It would be useful to have the DB version # in the SqlDialect for unparsing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
