[
https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480289#comment-16480289
]
Zoltan Haindrich commented on CALCITE-2247:
-------------------------------------------
[~julianhyde]: I've discovered that (x&&!x) might be problematic 1 week ago;
and 4 comments above you noted that if it was there before - it doesn't
matter....
now you say the opposite...
I'm not sure how fair is it to evaulate this patch on top of a partial of
CALCITE-2314...but to be sure that those failures are caused by this patch;
I've run the tests on [this
commit|https://github.com/julianhyde/calcite/commit/e594eea57fe54cf42a8feb7acdcc9986df60eee8]
; which came back with [32 failing
tests|http://sustaining-jenkins.eng.hortonworks.com:8080/view/calcite/job/calcite-check/63/testReport/]
since CALCITE-2314 in its own causes test failures, I'm not sure if this ticket
should be the one which start fixes those...
to my best
[knowledge|http://sustaining-jenkins.eng.hortonworks.com:8080/view/calcite/job/calcite-check/61/],
this patch is passing on top of the current master
(36b1d5c34f0f94cd95f832a0d9aa2e9f89210e1d)
I think a separate ticket should be opened to fix (x&&!x) problems
> Add rule to push in condition condition into a related disjunctive expression
> -----------------------------------------------------------------------------
>
> Key: CALCITE-2247
> URL: https://issues.apache.org/jira/browse/CALCITE-2247
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
>
> Simplify expressions like: {code}a = 1 AND (a = 1 OR a = 2){code} to {code}a
> = 1{code}
> Conditions to apply will be:
> * in an AND condition there exists a comparison(c) and an OR (o)
> * o and c only reference 1 variable
> See HIVE-19097 for more info.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
