[ 
https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482016#comment-16482016
 ] 

Julian Hyde commented on CALCITE-2247:
--------------------------------------

Thanks for the background, [~jcamachorodriguez]. It was I who made 
{{unknownAsFalse}} a field in {{RexSimplify}}, and that was a mistake.

I agree we need a parameter saying how UNKNOWN is handled. To be symmetric, we 
need 3 cases - unknown as true, false and unknown - rather just the 2 (false 
and unknown) we have now. Without the third case we cannot handle NOT or OR 
properly.

I'm working on fixing the test failures in the CALCITE-2314 dev branch. But 
that doesn't mean it hasn't found real problems.

> Add rule to push in condition condition into a related disjunctive expression
> -----------------------------------------------------------------------------
>
>                 Key: CALCITE-2247
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2247
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>
> Simplify expressions like: {code}a = 1 AND (a = 1 OR a = 2){code} to {code}a 
> = 1{code}
> Conditions to apply will be:
> * in an AND condition there exists a comparison(c) and an OR (o)
> * o and c only reference 1 variable
> See HIVE-19097 for more info.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to