[ 
https://issues.apache.org/jira/browse/CALCITE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482915#comment-16482915
 ] 

ASF GitHub Bot commented on CALCITE-2294:
-----------------------------------------

Github user apurtell commented on a diff in the pull request:

    https://github.com/apache/calcite-avatica/pull/48#discussion_r189683385
  
    --- Diff: 
server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ---
    @@ -274,7 +264,22 @@ protected void internalStart() {
         }
       }
     
    -  private ServerConnector getConnector() {
    +  protected void configureHandlers(ConstraintSecurityHandler 
securityHandler) {
    --- End diff --
    
    Is this type too narrow? Would there be other types of handlers that 
someone customizing the server would want to add to the list?


> Allow customization for AvaticaServerConfiguration for plugging new 
> authentication mechanisms
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2294
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2294
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Karan Mehta
>            Priority: Major
>
> {{AvaticaServerConfiguration}} is currently only created if authentication 
> mechanism such as {{BASIC, DIGEST or SPNEGO}} is provided. We can change it 
> to a builder pattern to create this object and provide a way for users to 
> plugin their own security configuration.
> An example here can be using it for custom config that supports MTLS.
> Thanks [~alexaraujo] for suggesting this approach.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to