[
https://issues.apache.org/jira/browse/CALCITE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483055#comment-16483055
]
ASF GitHub Bot commented on CALCITE-2294:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/48#discussion_r189711985
--- Diff:
server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ---
@@ -747,6 +758,10 @@ public HttpServer build() {
}
serverConfig = buildSpnegoConfiguration(this);
break;
+ case CUSTOM:
+ serverConfig = buildCustomConfiguration(this);
--- End diff --
Are you sure? I'm not sure this is doing anything. If I'm reading this
right, this line is effectively:
```java
serverConfig = this.serverConfig;
```
You already did this in `withCustomAuthentication`, so I'm not sure what
the intent is to do here. Please tell me if I'm missing something (I'm
admittedly not looking at this in an editor, so it might just be me)
> Allow customization for AvaticaServerConfiguration for plugging new
> authentication mechanisms
> ---------------------------------------------------------------------------------------------
>
> Key: CALCITE-2294
> URL: https://issues.apache.org/jira/browse/CALCITE-2294
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Karan Mehta
> Priority: Major
>
> {{AvaticaServerConfiguration}} is currently only created if authentication
> mechanism such as {{BASIC, DIGEST or SPNEGO}} is provided. We can change it
> to a builder pattern to create this object and provide a way for users to
> plugin their own security configuration.
> An example here can be using it for custom config that supports MTLS.
> Thanks [~alexaraujo] for suggesting this approach.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
