[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573410#comment-16573410
]
Vladimir Sitnikov commented on CALCITE-2457:
--------------------------------------------
[~asereda], that is an interesting point. I've no experience with those
libraries, however
1) I don't think JUnit assertions are that limiting. They are good enough for
simple cases. JUnit 5 adds more
2) More involved cases require Calcite-specific checks (e.g. plan
query/parse-unparse/apply some rules/etc), so "plain Truth/AssertJ" won't help
much AFAIK. Java is extremely limiting in adding "Calcite-specific" methods to
Truth/AssertJ assertions. We might want to apply some Kotlin, however that's a
bit of another story (do we have a ticket for that?).
3) I have no clue if Truth/AssertJ assertions are properly supported by IDE:
autocomplete must work, "diff view" must be available in case of test failure.
> Upgrade to JUnit 5
> ------------------
>
> Key: CALCITE-2457
> URL: https://issues.apache.org/jira/browse/CALCITE-2457
> Project: Calcite
> Issue Type: Improvement
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests
> with JUnit 5 features.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
