[ 
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573809#comment-16573809
 ] 

Andrei Sereda commented on CALCITE-2457:
----------------------------------------

For failure you don't like error message ? Or is it what you expected ? 

Re guava, Try [AssertJ|http://joel-costigliola.github.io/assertj/] it shouldn't 
have guava dependency. 

For primitives, numbers, strings there is no material difference between junit 
and fluent assertion framework. But for Arrays, Iterables, Maps, Exceptions 
things are easier. Also, one can create fluent assertion on the top of existing 
domain class [example for 
ProtoBuff|https://github.com/google/truth/blob/master/extensions/proto/src/main/java/com/google/common/truth/extensions/proto/ProtoSubject.java]s.
 

I'll let you ponder wherever such libraries bring any value to the project. 

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CALCITE-2457
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2457
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>         Attachments: truth_assertmap.png
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests 
> with JUnit 5 features.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to