[
https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603011#comment-16603011
]
Vladimir Sitnikov commented on CALCITE-2433:
--------------------------------------------
I'm inclined to merge the series of patches, so I could build a snapshot
version of Calcite to use in mat-calcite-plugin.
I do recognize the importance of the review process, however AFAIK no-one
raised a flag, and the fixes are related to rarely-used functionality (I wonder
if I am the only user of SqlAdvisor).
[~julianhyde], any thoughts?
> SqlAdvisor.getCompletionHints is hard-coded for " quoting
> ---------------------------------------------------------
>
> Key: CALCITE-2433
> URL: https://issues.apache.org/jira/browse/CALCITE-2433
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> Relevant source:
> {code:java}
> boolean quoted = false;
> while (wordStart > 0
> && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
> --wordStart;
> }
> if ((wordStart > 0)
> && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting
> from the connection
> quoted = true;
> --wordStart;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
