[
https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603677#comment-16603677
]
Julian Hyde commented on CALCITE-2433:
--------------------------------------
I think you are probably the only user of SqlAdvisor, and you are improving it
significantly, so we should get out of your way.
In Calcite review is optional - we trust committers. So, ask for review if you
think that you are doing something controversial, or if you would like help,
but usually you should just do it.
You may find it useful to start a discussion about the future of SqlAdvisor on
the dev list. If no one speaks up and says they are using it, or (equally
likely) if the current users are support all of the improvements you are
making, then consider that permission to make breaking API changes.
I think SqlAdvisor would be well served by extra documentation - say its own
page on the web site.
> SqlAdvisor.getCompletionHints is hard-coded for " quoting
> ---------------------------------------------------------
>
> Key: CALCITE-2433
> URL: https://issues.apache.org/jira/browse/CALCITE-2433
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> Relevant source:
> {code:java}
> boolean quoted = false;
> while (wordStart > 0
> && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
> --wordStart;
> }
> if ((wordStart > 0)
> && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting
> from the connection
> quoted = true;
> --wordStart;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
