[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617188#comment-16617188
]
Vladimir Sitnikov commented on CALCITE-2555:
--------------------------------------------
{quote}e2098d3073172b15882825bdc355755af1ae135e was created after my comment;
to address the issue I've described...{quote}
I do not get that either.
I got e2098d3073172b15882825bdc355755af1ae135e from a GitHub PR, then I tested
that, then you suppose I was using "bad version":
{quote}14 Sep 2018, 23:45 +0300 you have run your freaking checks on what
version????? I've just checked it with your original example because I wanted
to know where I was wrong...but now I'm seeing that the code have produced what
I described ....you've either executed the patched version or you have just run
your test against some rougue branch which didn't even contained it...{quote}
In other words:
1) pengzhiwei delivers e2098d3073172b15882825bdc355755af1ae135e on 21:02:00
2018 +0800
2) pengzhiwei adds "And I have fixed the problem" comment on 21:06:00 +0800
3) I check out the patch and test it on 21:19:00 +0800. Note that I explicitly
say that test "*current* edition of PR 831"
4) Then there's your moot point on "you've either executed the patched version
or you have just run your test against some rougue branch which didn't even
contained it". That was 7 hours later.
For the reference:
{noformat}commit e2098d3073172b15882825bdc355755af1ae135e
Author: pengzhiwei <...>
Date: Fri Sep 14 21:02:00 2018 +0800{noformat}
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
