[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620918#comment-16620918
]
Julian Hyde commented on CALCITE-2555:
--------------------------------------
In the commit message, I think you should express the change in terms of SQL
rather than API calls. Rather than {quote}RexSimplify: >=(..., null) could be
simplified to null{quote}, I think {quote}Simplify 'x >= NULL' to
'UNKNOWN'{quote} would be clearer for most people.
It's a minor point, but it's important, because people find out what is in
Calcite by reading the release notes.
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
> Fix For: 1.18.0
>
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
