[ 
https://issues.apache.org/jira/browse/CALCITE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622453#comment-16622453
 ] 

Vladimir Sitnikov commented on CALCITE-2451:
--------------------------------------------

{quote}We'd need to benchmark the whole planning process, including thousands 
of rule firings and invocations of RexSimplify. Would you be up for doing 
that?{quote}
That's fine with me

{quote}You could build a version of RexSimplify that maintains state for the 
whole process, and another version that does minimal object allocations{quote}
I don't want to implement things I don't like.
If anybody volunteers to implement multiple RexSimplify versions I'm fine with 
that.

> RexSimplify: fuse unknownAsFalse and IS TRUE handling
> -----------------------------------------------------
>
>                 Key: CALCITE-2451
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2451
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> It looks like {{unknownAsFalse}} duplicates {{IS_TRUE}} handling.
> In other words, {{withUnknownAsFalse(true). simplfy(expr)}} is more or less 
> comparable to {{simplify(isTrue(expr))}}
> Implementing {{IS_TRUE/IS_FALSE/...}} simplification possibilities might make 
> {{unknownAsFalse}} obsolete.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to