[ 
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795191#comment-16795191
 ] 

Andrei Sereda commented on CALCITE-2457:
----------------------------------------

Following dev list 
[discussion|https://lists.apache.org/thread.html/3c2e87359442eefbce67823926d3701e2541df1c798025be4a31e779@%3Cdev.calcite.apache.org%3E]
 it seems there is no appetite for such upgrade.

Main reasons:
# If fully upgraded, introduces too much noise in source and git history. Eg. 
{{@org.junit.Test}} -> {{@org.junit.jupiter.api.Test}} replace) 
#  [Parallel 
execution|https://junit.org/junit5/docs/current/user-guide/#writing-tests-parallel-execution]
 feature (used by maven surefire / failsafe) is still experimental. 

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CALCITE-2457
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2457
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Vladimir Sitnikov
>            Assignee: Andrei Sereda
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: assert_equals.png, truth_assertmap.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests 
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to