[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795243#comment-16795243
]
Vladimir Sitnikov commented on CALCITE-2457:
--------------------------------------------
{quote}I don't see how Junit 5 and refactoring JdbcTest / SqlValidatorTest are
connected{quote}
[~julianhyde], JUnit 5 opens new possibilities for refactoring.
As far as I understand, we should be able to use JUnit 5 runner with current
test codebase.
Then we could apply relevant JUnit 5 features to "known to be sad" classes
(e.g. JdbcTest).
It does connect refactor and JUnit 5.
> Upgrade to JUnit 5
> ------------------
>
> Key: CALCITE-2457
> URL: https://issues.apache.org/jira/browse/CALCITE-2457
> Project: Calcite
> Issue Type: Improvement
> Reporter: Vladimir Sitnikov
> Assignee: Andrei Sereda
> Priority: Major
> Labels: pull-request-available
> Attachments: assert_equals.png, truth_assertmap.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
