[ 
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795255#comment-16795255
 ] 

Vladimir Sitnikov commented on CALCITE-2457:
--------------------------------------------

[~sereda], I think the case is just "not enough will" / "not enough time" to 
make the change.

Of course current setup works. Of course there's no much sense in just 
replacing annotation names all over the place.

However, proper use of new features (e.g. advanced asserts / extensions) might 
easily make code easier to maintain, and easier to read.

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CALCITE-2457
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2457
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Vladimir Sitnikov
>            Assignee: Andrei Sereda
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: assert_equals.png, truth_assertmap.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests 
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to