[ 
https://issues.apache.org/jira/browse/CALCITE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797938#comment-16797938
 ] 

Hongze Zhang commented on CALCITE-883:
--------------------------------------

{quote}
with my understanding the first operand of RexOver may become a "NULL 
TREATMENT" operator rather than an aggregate operator
{quote}
I think the operator "NULL TREATMENT" should not appears at Rel / Rex level. 
You can translate it to a flag field of RexOver in SqlToRelConverter. See 
how[1] does the converter handles aggregate calls to which {{WITHIN GROUP}} or 
{{FILTER}} is used.

[1] 
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L4433

> RESPECT NULLS, IGNORE NULLS option for LEAD, LAG window functions
> -----------------------------------------------------------------
>
>                 Key: CALCITE-883
>                 URL: https://issues.apache.org/jira/browse/CALCITE-883
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Sean Hsuan-Yi Chu
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This issue was brought up in Drill community: 
> (https://issues.apache.org/jira/browse/DRILL-3597)
> For convenience, I copied and pasted the reporter Khurram Faraaz's 
> description here:
> "The SQL standard defines a RESPECT NULLS or IGNORE NULLS option for lead, 
> lag, first_value, and last_value window functions."
> In Calcite, we should have been able to recognized this option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to